Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extract: semver aware #6800

Merged
merged 1 commit into from Dec 4, 2019
Merged

extract: semver aware #6800

merged 1 commit into from Dec 4, 2019

Conversation

figroc
Copy link
Contributor

@figroc figroc commented Dec 2, 2019

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

It's related to #6793.

MikeMcQuaid
MikeMcQuaid reviewed Dec 2, 2019
View reviewed changes
Library/Homebrew/dev-cmd/extract.rb Show resolved Hide resolved
Library/Homebrew/dev-cmd/extract.rb Outdated Show resolved Hide resolved
Library/Homebrew/test/dev-cmd/extract_spec.rb Outdated Show resolved Hide resolved
Library/Homebrew/test/dev-cmd/extract_spec.rb Show resolved Hide resolved
@MikeMcQuaid
Copy link
Member

Thanks for the PR @figroc! A few questions for now.

MikeMcQuaid
MikeMcQuaid reviewed Dec 2, 2019
View reviewed changes
Library/Homebrew/dev-cmd/extract.rb Outdated Show resolved Hide resolved
Library/Homebrew/dev-cmd/extract.rb Outdated Show resolved Hide resolved
Library/Homebrew/dev-cmd/extract.rb Outdated Show resolved Hide resolved
Library/Homebrew/dev-cmd/extract.rb Outdated Show resolved Hide resolved
Library/Homebrew/dev-cmd/extract.rb Outdated Show resolved Hide resolved
@figroc
Copy link
Contributor Author

figroc commented Dec 2, 2019 •
edited

@MikeMcQuaid Would you kindly take another look?

@figroc
Copy link
Contributor Author

figroc commented Dec 3, 2019

GitHub Actions CI / tests (macOS-latest) (pull_request) Failing after 22m

I can't see the detailed logs. Not sure what happened. The tests ran ok on my macOS.

@MikeMcQuaid
Copy link
Member

@figroc I think that was a GitHub Actions bug. If you git rebase you should be able to see now (as there's a conflict anyway).

@MikeMcQuaid MikeMcQuaid removed their request for review December 3, 2019 11:43
@figroc
Copy link
Contributor Author

figroc commented Dec 3, 2019

I've stripped all the trailing if ARGV.debug? from odebug calls. Let me know if that is not appropriate.

@MikeMcQuaid MikeMcQuaid merged commit 4a7ea6d into Homebrew:master Dec 4, 2019
@MikeMcQuaid
Copy link
Member

Thanks so much for your contribution! Without people like you submitting PRs we couldn't run this project. You rock, @figroc!

@lock lock bot added the outdated PR was locked due to age label Jan 3, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid left review comments

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@figroc @MikeMcQuaid